NewClient() can't handle credentials containing characters such as / #39
Conversation
…haracters Depending on the contents of the username and password the default url.Parse may not work. The below is an example URL that would end up being parsed incorrectly with url.Parse: http://admin:ZOSOKjgV/kgEkN0bzPJp+oGeJLqpXykqWFJpon/Ckg@localhost:38607 So instead of depending on url.Parse we'll try using a regular expression first to match a specific pattern instead. This won't be 100% reliable in all cases which is why we fall back onto using url.Parse anyway.
|
@andygrunwald, please take a look. Discovered this while working on gerrittest which connects to a container and asks Gerrit to generate a password (which in turns breaks NewClient() because of the '/' character). Once this merges we probably should go ahead and release 0.4.0. EDIT And the test generating the failure is here: https://github.com/opalmer/gerrittest/blob/f85732e99ad39a58b0e5ef2913fb6e4bbc87792a/cmd/subcommands/integration_test.go#L50 Basically this is:
|
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 17.79% 17.94% +0.14%
==========================================
Files 21 21
Lines 1742 1750 +8
==========================================
+ Hits 310 314 +4
- Misses 1398 1403 +5
+ Partials 34 33 -1
Continue to review full report at Codecov.
|
|
Another good one! |
See commit ba033b0 for an explanation.